Add test for retrieving block by hash#110
Closed
tgmichel wants to merge 1 commit intopolkadot-evm:masterfrom
Closed
Add test for retrieving block by hash#110tgmichel wants to merge 1 commit intopolkadot-evm:masterfrom
tgmichel wants to merge 1 commit intopolkadot-evm:masterfrom
Conversation
Contributor
Author
|
Once #113 goes through, the test should work. |
Member
|
Please pull master. |
Contributor
|
#134 fixes this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes calling
eth_getBlockByHashor usingweb3.eth.getBlock(using a hash) is returningnullinstead of the block's body.This PR adds the assertion to the typescript tests.
P.S. the PR fails obviously on functional tests ->
AssertionError: Target cannot be null or undefined.