Skip to content

Check EIP-3607 at transaction validation #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorpaas merged 3 commits into from
Jul 30, 2023
Merged

Check EIP-3607 at transaction validation #1084

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acf6d31
check EIP-3607 at transaction validation
librelois Jun 21, 2023
606e6fd
fix rust compilation
librelois Jun 21, 2023
37b8506
clippy
librelois Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions frame/ethereum/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,16 @@ impl<T: Config> Pallet<T> {
.and_then(|v| v.with_balance_for(&who))
.map_err(|e| e.0)?;

// EIP-3607: https://eips.ethereum.org/EIPS/eip-3607
// Do not allow transactions for which `tx.sender` has any code deployed.
//
// This check should be done on the transaction validation (here) **and**
// on trnasaction execution, otherwise a contract tx will be included in
Copy link
Copy Markdown
Contributor

@tgmichel tgmichel Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// on trnasaction execution, otherwise a contract tx will be included in
// on transaction execution, otherwise a contract tx will be included in

// the mempool and pollute the mempool forever.
if !pallet_evm::AccountCodes::<T>::get(origin).is_empty() {
return Err(InvalidTransaction::BadSigner.into());
}

let priority = match (
transaction_data.gas_price,
transaction_data.max_fee_per_gas,
Expand Down