fp-account by bernardoaraujor · Pull Request #1019 · polkadot-evm/frontier

bernardoaraujor · 2023-03-15T21:34:12Z

Based on Moonbeam's AccountId20 implementation:

Introduces a new fp-account crate into primitives, as an alternative to Frontier's H256->H160 truncation mapping.

H160 addresses live natively on the Substrate runtime, and there's no need for translation between H256 and H160.

sorpaas

LGTM otherwise

… directly Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

yjhmelody · 2023-03-16T07:54:29Z

+}
+
+impl From<ecdsa::Public> for AccountId20 {
+	fn from(pk: ecdsa::Public) -> Self {


I think this logic should not be implmented in a From. It is not a cheap convert.

what would you suggest as alternative?

I think this should be okay. I don't recall any restrictions that we shouldn't use From for expensive convert.

yjhmelody · 2023-03-16T07:56:51Z

+
+#[derive(Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Default)]
+#[derive(Encode, Decode, MaxEncodedLen, TypeInfo)]
+pub struct AccountId20(pub [u8; 20]);


Should add more docs for these types. e.g. eth compatible address blah blah.

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

* bootstrap fp-account * clippy * make IdentityAddressMapping support From<H160> * clippy * fix import warning * fix pallet-evm tests * fix pallet-hotfix-sufficients tests * use libsecp256k1::PublicKey::parse_compressed and sp_core::keccak_256 directly Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * simplify keccak_256 hashing Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * format derives Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * merge_derives = false * fix imports * impl Debug for AccountId20 * simplify Display for EthereumSigner Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * fmt * simplify keccak_256 hashing * simplify ecdsa path Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * format derives Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * use sp_io for keccak_256 Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * remove sha3 dependency Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * remove sha3 dependency Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * remove sha3 dependency Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * remove sha3 import * remove sha3 dependency * simplify keccak_256 hashing on tests Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * remove serde imports Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> * add account docs * remove sp-keyring from template deps --------- Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com> Co-authored-by: Wei Tang <wei@pacna.org>

bootstrap fp-account

bd2da65

bernardoaraujor added the enhancement New feature or request label Mar 15, 2023

bernardoaraujor requested a review from sorpaas as a code owner March 15, 2023 21:34

clippy

20e7806

bernardoaraujor force-pushed the bar/fp-account branch from 3598379 to 20e7806 Compare March 15, 2023 22:14

sorpaas reviewed Mar 15, 2023

View reviewed changes

Comment thread frame/evm/src/lib.rs Outdated

sorpaas reviewed Mar 15, 2023

View reviewed changes

make IdentityAddressMapping support From<H160>

0e396b1

sorpaas approved these changes Mar 15, 2023

View reviewed changes

clippy

63a4403

bernardoaraujor force-pushed the bar/fp-account branch from 44eec1f to 63a4403 Compare March 15, 2023 23:21

bernardoaraujor added 3 commits March 15, 2023 20:42

fix import warning

b2610f8

fix pallet-evm tests

434c463

fix pallet-hotfix-sufficients tests

f42e985

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

use libsecp256k1::PublicKey::parse_compressed and sp_core::keccak_256…

1816c53

… directly Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

bernardoaraujor and others added 3 commits March 15, 2023 23:53

simplify keccak_256 hashing

09cbbc2

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

format derives

c17dd3a

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

merge_derives = false

46efbd4

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread template/node/src/benchmarking.rs Outdated

fix imports

bc512bc

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread frame/ethereum/src/lib.rs Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/Cargo.toml Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/Cargo.toml Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread Cargo.toml Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

bernardoaraujor and others added 11 commits March 16, 2023 00:15

simplify Display for EthereumSigner

2524979

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

fmt

8f27a64

simplify keccak_256 hashing

6bbb24b

simplify ecdsa path

849dea9

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

format derives

9ff7471

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

use sp_io for keccak_256

74dde28

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

remove sha3 dependency

dc9e114

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

remove sha3 dependency

1c4a25a

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

remove sha3 dependency

4ab0301

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

remove sha3 import

4c90a2d

remove sha3 dependency

3ec257f

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

koushiro reviewed Mar 16, 2023

View reviewed changes

Comment thread primitives/account/src/lib.rs Outdated

yjhmelody reviewed Mar 16, 2023

View reviewed changes

bernardoaraujor and others added 5 commits March 16, 2023 10:52

simplify keccak_256 hashing on tests

157adb4

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

remove serde imports

75d6b91

Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>

add account docs

72946e2

Merge branch 'master' into bar/fp-account

ca54a7a

remove sp-keyring from template deps

cee0f91

koushiro approved these changes Mar 17, 2023

View reviewed changes

sorpaas merged commit 43616e4 into master Mar 17, 2023

sorpaas deleted the bar/fp-account branch March 17, 2023 21:28

koushiro mentioned this pull request Mar 20, 2023

Add fp_account::AccountId20 mapping polkadot-js/api#5551

Merged

aurexav mentioned this pull request Mar 23, 2023

Use frontier account primitives darwinia-network/darwinia#1063

Closed

bernardoaraujor mentioned this pull request Apr 20, 2023

AccountId20 on Frontier Template Node polkadot-js/apps#9355

Closed

bernardoaraujor mentioned this pull request May 12, 2023

fix prefunded accounts for proper development experience on PolkadotJS Apps #1053

Merged

bernardoaraujor mentioned this pull request May 21, 2023

split template into 2 opinionated runtimes: AccountId20 + AccountId32 #1056

Open

dmitrylavrenov mentioned this pull request Oct 16, 2023

Bump to polkadot-sdk v1.1.0 as a base for substrate related deps humanode-network/humanode#803

Closed

37 tasks

Conversation

bernardoaraujor commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sorpaas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yjhmelody Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernardoaraujor Mar 16, 2023

Choose a reason for hiding this comment

Uh oh!

sorpaas Mar 16, 2023

Choose a reason for hiding this comment

Uh oh!

yjhmelody Mar 16, 2023

Choose a reason for hiding this comment

Uh oh!

bernardoaraujor Mar 16, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernardoaraujor commented Mar 15, 2023 •

edited

Loading

yjhmelody Mar 16, 2023 •

edited

Loading