[How-to] Update how to guide to use the define-benchmark syntax instead of add…#1378
Merged
lisa-parity merged 2 commits intomainfrom Aug 11, 2022
Merged
[How-to] Update how to guide to use the define-benchmark syntax instead of add…#1378lisa-parity merged 2 commits intomainfrom
lisa-parity merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for substrate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
|
@ggwpez, if you get a change to take a look here is some updated doc to replace add-benchmark (and other changes). |
ggwpez
reviewed
Aug 9, 2022
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
| After you update the runtime, you are ready to compile it with the `runtime-benchmarks` features enabled and start the benchmarking analysis for your pallet. | ||
|
|
||
| 1. Build your project with the benchmarks enabled: | ||
| 1. Change to the root directory for the node template. |
Contributor
There was a problem hiding this comment.
It is probably more robust to select the exact crate with the -p flag, but not a must.
So rather adding -p node-template to the build command below than changing the directory.
Contributor
Author
There was a problem hiding this comment.
yeah, that's better. Changed.
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
lisa-parity
commented
Aug 9, 2022
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
| After you update the runtime, you are ready to compile it with the `runtime-benchmarks` features enabled and start the benchmarking analysis for your pallet. | ||
|
|
||
| 1. Build your project with the benchmarks enabled: | ||
| 1. Change to the root directory for the node template. |
Contributor
Author
There was a problem hiding this comment.
yeah, that's better. Changed.
content/md/en/docs/reference/how-to-guides/weights/add-benchmarks.md
Outdated
Show resolved
Hide resolved
lisa-parity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-benchmark