Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io Migration] - Polkadot Protocol > Protocol Operations > Off-Chain Operations #87

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nhussein11
Copy link
Collaborator

This PR aims to migrate this page: https://docs.substrate.io/learn/offchain-operations/

Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides these small changes LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert image to .webp

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that image as temporal because I'm sure it should be converted into a mermaid diagram...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want @dawnkelly09 to take a look at this? she's been making some pretty diagrams 😍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please! @dawnkelly09 🙏

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemme see what I can cook up!

polkadot-protocol/protocol-operations/.pages Outdated Show resolved Hide resolved
@dawnkelly09
Copy link
Collaborator

Ok, friends! Did a round of grammar/formatting and editing to this one and added some mermaid diagrams. Let's see what you think!

@dawnkelly09 dawnkelly09 requested review from eshaben and 0xLucca and removed request for dawnkelly09 October 15, 2024 17:59
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dawnkelly09
Copy link
Collaborator

dawnkelly09 commented Oct 16, 2024

@eshaben I moved this copy to the Polkadot SDK page for the moment and have this specific file tagged with TODO to delete once the new copy is approved. Needs a grammar and formatting pass from you, please. WDYT of Further Resources as an interface admonition at the end of each section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants