-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Substrate.io Migration] - Polkadot Protocol > Protocol Components > Transactions > Transactions Weights and Fees #85
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this page seems accurate. It would be nice to include some information on metering in the future.
I would like to try out some of this code before explicitly approving, but it can most likely be approved as-is.
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Outdated
Show resolved
Hide resolved
…s-weights-and-fees.md Co-authored-by: bader y <[email protected]>
…s-weights-and-fees.md Co-authored-by: bader y <[email protected]>
…s-weights-and-fees.md Co-authored-by: bader y <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall ok. I haven't tested the code snippets
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Outdated
Show resolved
Hide resolved
...ets/code/polkadot-protocol/trasactions/transactions-weights-and-fees/operational-dispatch.rs
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-weights-and-fees.md
Outdated
Show resolved
Hide resolved
Co-authored-by: 0xLucca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR aims to migrate this page of the substrate tutorials: https://docs.substrate.io/build/tx-weights-fees/