Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io Migration] - Polkadot Protocol > Protocol Components > Transactions > Transactions Weights and Fees #85

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nhussein11
Copy link
Collaborator

This PR aims to migrate this page of the substrate tutorials: https://docs.substrate.io/build/tx-weights-fees/

Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this page seems accurate. It would be nice to include some information on metering in the future.

I would like to try out some of this code before explicitly approving, but it can most likely be approved as-is.

Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall ok. I haven't tested the code snippets

@nhussein11 nhussein11 requested a review from a team October 9, 2024 12:04
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants