[Substrate.io Migration] - Polkadot Protocol > Protocol Components > Transactions > Transactions Formats #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
CrackTheCode016
previously approved these changes
Oct 4, 2024
0xLucca
reviewed
Oct 4, 2024
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
|
|
||
| Then, some additional data that's not part of what gets signed is required, which includes: | ||
|
|
||
| - The spec version and the transaction version ensure that the transaction is submitted to a [compatible runtime](TODO:update-path){target=\_blank} |
There was a problem hiding this comment.
What would you link in compatible runtime?
There was a problem hiding this comment.
One of the bader's suggestions were linking this part with "Upgrade your runtime"
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
Co-authored-by: 0xLucca <[email protected]>
|
Pushed a few formatting changes |
eshaben
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Some minor formatting stuff. But I also left a comment about linking to specific lines. I didn't actually check to see if we could link to another part of the Rust docs, but can you please look into it and see if we can do that instead of specific file lines?
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
polkadot-protocol/protocol-components/transactions/transactions-formats.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Erin Shaben <[email protected]>
|
Just requesting re-review for pending approvals |
CrackTheCode016
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate this page of the substrate tutorials: https://docs.substrate.io/learn/transaction-formats/
Disclaimer: I did not migrate this section: https://docs.substrate.io/reference/transaction-format/#:~:text=Polkadot%20JS%20Apps%20example%3A
Since I believe that would fit better in the tutorials section, maybe we can add a reference to that part in the future. However, I'm open to discuss about it :)