Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Polkadot Wiki Migration] Upgrade Your Node #36

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

CrackTheCode016
Copy link
Collaborator

@dawnkelly09
Copy link
Collaborator

Scan for Vale false positives. Resolved convos = made it on the update list and should go away now. I left comments for the legit flags with suggested edits. Thank you!

Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some formatting/grammar edits and moved terminal to snippets, etc.
@polkadot-developers/docs-content-team please see my comments on content needs --- make sure you check out the snippet for the terminal output because it is missing the command. Please request new format review after updates. Thanks!


## Steps

The following steps require a second validator which will be referred to as `Validator B`. The
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be a quick overview of which steps are needed with a more extensive tutorial somewhere else? If there isn't a more detailed tutorial to go with this, then some of these steps should have more detail. What commands do I use to start a second node? How do I generate session keys? etc. This section has a nice amount of "what" but almost no "how"

Copy link
Collaborator

@eshaben eshaben Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are steps they most likely (if not, someone on their team) would have already gone through when setting up the original validator.

I would just add a link to the onboarding page, which will include how to get a node up and running and how to generate session keys

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another note: I think this page will get heavily updated at some point, so I would link to other places for now where needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked the "How to Validate" page, which covers this as a prerequisite. We can definitely make it flow a little better, though.

**Validator B** is now acting as your validator - you can safely perform operations on **Validator
A**.

When you are ready to restore **Validator A**:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above. Do we need more how in here or will there be tutorial(s) to link out to?


## Prerequisites

Before continuining with this guide, ensure you have:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some things the user should already be familiar with, might want to read first, stuff to ensure they have installed, etc., before continuing with this guide.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great place to add that they'll need to set up a secondary validator


## Prerequisites

Before continuining with this guide, ensure you have:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great place to add that they'll need to set up a secondary validator

@0xLucca
Copy link
Collaborator

0xLucca commented Oct 7, 2024

Hey @CrackTheCode016,

I'd like to clarify the objective of this section. The current process seems to involve:

  1. Spinning up an additional validator (B)
  2. Applying fixes and upgrades to the original validator (A)
  3. Restarting validator A

Wouldn't it be more efficient to apply all changes to the server of validator B before starting it? This reduces the process time from (N+3) * 2 sessions to N+3 sessions

Could you please elaborate on the rationale behind the current method? Maybe there are specific advantages to this approach that I might be overlooking

@CrackTheCode016 CrackTheCode016 requested a review from a team as a code owner October 15, 2024 21:32
@CrackTheCode016
Copy link
Collaborator Author

@0xLucca This appears to me like it would work, I'll ping infra and get a final answer before making any changes.

@BulatSaif
Copy link

Good to go! I like that you emphasized the importance of waiting for 2 full sessions—it’s really important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants