relax plugin macro's requirements on field values #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From "string literal" to basically still "string literal", but now you can use macros to generate the string literal. Did I mention string literals? Anyway, this is particularly useful in combination with the `env!()` macro and the environment variables `cargo` sets at build time.
|
Thanks, we'll wait for the nightly requirement to be lifted but it's nice to keep it here, also I don't really expect this PR to bitrot. |
|
While this implementation is probably fine, note that the |
|
I'm just going to close this since I honestly don't have any desire to fix this anymore. I think it should be possible to do this on stable rust now though if anyone else wants to pick it back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From "string literal" to basically still "string literal", but now you can use macros to generate the string literal. Did I mention string literals? Anyway, this is particularly useful in combination with the
env!()macro and the environment variablescargosets at build time.See #28 for initial discussion. Also, I've done a force-push to add a few comments since then. And just to make things easier to follow/reference, I'll restate here that these changes currently require downstream crates to use a nightly toolchain due to rust-lang/rust#51911.