ENH: Add version to non-release Docker images. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
maint/fix_version
branch
from
e226d44 to
31b13d1
Compare
|
@oesteban Can you see what's wrong with this? |
effigies
force-pushed
the
maint/fix_version
branch
from
0d59e0d to
3520b1d
Compare
effigies
commented
Apr 29, 2019
| @@ -20,6 +20,7 @@ description-file = README.rst | |||
|
|
|||
| [options] | |||
| packages = find: | |||
| include_package_data = True | |||
There was a problem hiding this comment.
@oesteban Just FYI this was the issue. See https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117. Hopefully also fixes pip issue first identified in #135 (comment).