Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer poll response should include offset #40

Closed
jorgebay opened this issue Oct 4, 2022 · 0 comments · Fixed by #46
Closed

Consumer poll response should include offset #40

jorgebay opened this issue Oct 4, 2022 · 0 comments · Fixed by #46
Assignees
@jorgebay
Labels
bug Something isn't working
Milestone
0.2.0

Comments

@jorgebay
Copy link
Contributor

jorgebay commented Oct 4, 2022

Currently, the response does not include the offset of the payload: https://github.com/barcostreams/barco/blob/main/docs/developer/NETWORK_FORMATS.md#consumer-poll-response

The poll response should contain the offset for bookeeping after the topic name.
@jorgebay jorgebay added the bug Something isn't working label Oct 4, 2022
@jorgebay jorgebay added this to the 0.2.0 milestone Oct 4, 2022
@jorgebay jorgebay mentioned this issue Oct 4, 2022
Closed
@jorgebay jorgebay self-assigned this Oct 5, 2022
jorgebay added a commit that referenced this issue Oct 5, 2022
@jorgebay
Include offset in consumer poll response
67957db 
Resolves #40.
@jorgebay jorgebay mentioned this issue Oct 5, 2022
Merged
jorgebay added a commit that referenced this issue Oct 7, 2022
@jorgebay
Include offset in consumer poll response
11d3f91 
Resolves #40.
jorgebay added a commit that referenced this issue Oct 10, 2022
@jorgebay
Include offset in consumer poll response
ddcc496 
Resolves #40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgebay jorgebay

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Include offset in consumer poll response polarstreams/polar
1 participant
@jorgebay