large files need more than 10 minutes to upload.#8782
large files need more than 10 minutes to upload.#8782frankie567 merged 1 commit intopolarsource:mainfrom
Conversation
|
@obrienciaran is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
|
Is there anybody who could take a look at this 🙏 ? I'm totally blocked by this! The final step before my product goes live is testing the checkout flow with Polar but I can't upload my files! Maybe @Yopi @psincraian @frankie567 (apologies if I'm tagging the wrong people or missing anything from the PR, but it is a simple one). |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Hi @obrienciaran, thank you for the PR, and solving the issue on your own! I think we might want to rework this or have a different way to upload large files to avoid hitting this timeout when the user has a slow internet connection, but I think for now this works -- if it's enough for you. |
|
Thank you very much @Yopi It's an interesting one - I tried to upload on a few different networks, but each timed out on a 2.9gb upload with the short window. I think the solution of simply increasing the signed URL is sufficient for now. But I look forward to new developments in future 😄 Thanks for jumping on this so fast. |
|
No worries. The change should be out in production now @obrienciaran. I hope it's smooth sailing from now on, but otherwise let me know! |
|
I just had another look @Yopi , I see that Terraform was overwriting the Pydantic I've changed the Terraform |
Should have verified that it was completed yesterday, sorry about that! I have applied the terraform from your other PR now. It looks like it's working with longer file uploads now! |
|
Thanks for the approval. It was my fault for not double checking, I didn't realise Terraform overwrites config files like that. I can confirm the signed URLs are now 1 hour for uploads on my end too. |
📋 Summary
Related Issue: Fixes #8745
Increase signed URL expiration time to 3600 seconds to allow large file uploads.
🎯 What
Increases timeout to 1 hour. This balances functionality with security.
🤔 Why
Large files fail to upload before the 10 minute signed URL expires, even with a decent connection.
🔧 How
Increases timeout to 3600 seconds.
🧪 Testing
uv run task testfor backend,pnpm testfor frontend)uv run task lint && uv run task lint_typesfor backend)Test Instructions
NA
🖼️ Screenshots/Recordings
📝 Additional Notes
NA
✅ Pre-submission Checklist
NA