fix: include the cursor pointer on the close button for hover effect#8749
Open
fahdbahri wants to merge 2 commits intopolarsource:mainfrom
Open
fix: include the cursor pointer on the close button for hover effect#8749fahdbahri wants to merge 2 commits intopolarsource:mainfrom
fahdbahri wants to merge 2 commits intopolarsource:mainfrom
Conversation
|
@fahdbahri is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Good catch, thanks 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Related Issue: N/A (minor fix)
🎯 What
In the checkout session, i added the
cursor-pointeron the close button.🤔 Why
The element was already clickable, but the cursor did not reflect that,
making it appear broken or non-interactive.
🔧 How
Added the missing
cursor-pointerstyle to the existing component.No logic or behavior changes were made.
🧪 Testing
uv run task testfor backend,pnpm testfor frontend)uv run task lint && uv run task lint_typesfor backend)Test Instructions
🖼️ Screenshots/Recordings
Before
checkout_before.mp4
After
checkout_after.mp4
✅ Pre-submission Checklist