Skip to content

fix: include the cursor pointer on the close button for hover effect#8749

Open
fahdbahri wants to merge 2 commits intopolarsource:mainfrom
fahdbahri:polar-checkout-close
Open

fix: include the cursor pointer on the close button for hover effect#8749
fahdbahri wants to merge 2 commits intopolarsource:mainfrom
fahdbahri:polar-checkout-close

Conversation

@fahdbahri
Copy link

📋 Summary

Related Issue: N/A (minor fix)

🎯 What

In the checkout session, i added the cursor-pointer on the close button.

🤔 Why

The element was already clickable, but the cursor did not reflect that,
making it appear broken or non-interactive.

🔧 How

Added the missing cursor-pointer style to the existing component.
No logic or behavior changes were made.

🧪 Testing

  • I have tested these changes locally
  • All existing tests pass (uv run task test for backend, pnpm test for frontend)
  • I have added new tests for new functionality
  • I have run linting and type checking (uv run task lint && uv run task lint_types for backend)

Test Instructions

  1. Navigate to the effected page
  2. Hover over to the close button
  3. Verify the cursor changes to a pointer

🖼️ Screenshots/Recordings

Before

checkout_before.mp4

After

checkout_after.mp4

✅ Pre-submission Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated the relevant tests
  • All tests pass locally
  • AI/LLM Policy: If I used AI assistance, I have tested and executed the code locally (not just "vibe-coded")

@vercel
Copy link

vercel bot commented Jan 4, 2026

@fahdbahri is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

@frankie567 frankie567 enabled auto-merge (rebase) January 29, 2026 14:39
@frankie567
Copy link
Member

Good catch, thanks 🙏

@frankie567 frankie567 disabled auto-merge January 29, 2026 14:48
@frankie567 frankie567 enabled auto-merge (squash) January 29, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants