worker: MemoryTraceMiddleware using tracemalloc #8531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
birkjernstrom
changed the title
birkjernstrom
force-pushed
the
fix/worker-task-memory
branch
from
2325399 to
d4d8de0
Compare
Yopi
approved these changes
Dec 14, 2025
Contributor
Yopi
left a comment
Yopi
left a comment
There was a problem hiding this comment.
I think this will be useful to get out
| if not self.enabled: | ||
| return | ||
|
|
||
| self._before_message = tracemalloc.take_snapshot() |
Contributor
There was a problem hiding this comment.
I think we need to store these in a thread safe way, either in a thread local variable or on the message. E.g.
message.options['_memory_snapshot'] = tracemalloc.take_snapshot()
Alterantively in __init__ we could do
self._state = threading.local()
and store it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.