feat(fee_credits): Ability to grant payment fee credits #8480

birkjernstrom · 2025-12-11T15:40:28Z

No description provided.

vercel · 2025-12-11T15:40:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
polar	Ignored	Preview	Jan 5, 2026 4:40pm
polar-sandbox	Ignored	Preview	Jan 5, 2026 4:40pm

github-actions · 2025-12-11T15:43:02Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

server/polar/backoffice/organizations_v2/endpoints.py

github-actions · 2025-12-11T15:44:34Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-17T13:51:37Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-17T13:57:28Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-17T13:59:51Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-25T21:41:14Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-25T21:44:04Z

🚀 Expo preview is ready!

Project → Polar
Platforms → android, ios
Scheme → polar
Runtime Version → 1.2.0
More info

Learn more about 𝝠 Expo Github Action

github-actions · 2025-12-25T21:50:10Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-25T22:47:23Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-25T22:48:54Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-25T22:53:31Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-26T21:19:42Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-26T21:24:22Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

frankie567

Looks good!

A few suggestions implementation-wise, but the underlying logic feels solid.

server/polar/notifications/notification.py

server/polar/account_credit/service.py

psincraian

Some small comments

psincraian · 2026-01-05T08:31:50Z

server/migrations/versions/2025-12-17-1454_.py

+# Polar Custom Imports
+
+# revision identifiers, used by Alembic.
+revision = "400b90a4d953"


this one is not needed

psincraian · 2026-01-05T08:32:00Z

server/migrations/versions/2025-12-25-2246_.py

+# Polar Custom Imports
+
+# revision identifiers, used by Alembic.
+revision = "0a8d663cc43d"


this file is not needed

psincraian · 2026-01-05T08:32:38Z

server/migrations/versions/2025-12-26-2221_.py

+# Polar Custom Imports
+
+# revision identifiers, used by Alembic.
+revision = "99e264e9af83"


migration not needed

server/polar/account_credit/service.py

psincraian · 2026-01-05T08:43:11Z

server/polar/account_credit/service.py

+        session.add(account)
+
+        await session.flush()
+        return (amount_applied, credits_used)


can we use a dataclass for this? returning tuples can be confusing for public methods

github-actions · 2026-01-05T16:10:48Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2026-01-05T16:12:26Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2026-01-05T16:26:01Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2026-01-05T16:43:17Z

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

psincraian

Nice job!

github-advanced-security bot found potential problems Dec 11, 2025

View reviewed changes

server/polar/backoffice/organizations_v2/endpoints.py Dismissed Show dismissed Hide dismissed

server/polar/backoffice/organizations_v2/endpoints.py Dismissed Show dismissed Hide dismissed

emilwidlund force-pushed the feat/credits branch from 1ca42dd to 3e0a0f4 Compare December 17, 2025 13:49

emilwidlund force-pushed the feat/credits branch from 086362f to e8ebccb Compare December 25, 2025 21:47

birkjernstrom and others added 13 commits December 26, 2025 22:21

feat(fee_credits): Ability to grant payment fee credits

fdba7aa

refactor(fee_credit): Remove unused model method

dbe9e43

fees: polish fee credits

7ef1569

merge heads

111dbca

lint

3a19aa4

account_credits: implement notifications and emails for account credits

4670d9f

merge alembic heads

7723780

credits: fix migrations

0511434

fix imports

f6bc19f

fix credits migrations

38dfec9

fix tests

36d6a5f

fix variables

5bbdfc9

merge migrations

593408e

emilwidlund force-pushed the feat/credits branch from 5f45ad8 to 593408e Compare December 26, 2025 21:21

frankie567 reviewed Jan 5, 2026

View reviewed changes

server/polar/notifications/notification.py Show resolved Hide resolved

server/polar/account_credit/service.py Outdated Show resolved Hide resolved

psincraian reviewed Jan 5, 2026

View reviewed changes

emilwidlund added 2 commits January 5, 2026 17:08

server: add repository to account_credit logic

0ab4772

adjust migrations

7ff9b79

server: adjust migrations

1900220

migrations: cleanup migrations

6be9f9c

psincraian approved these changes Jan 5, 2026

View reviewed changes

emilwidlund marked this pull request as ready for review January 5, 2026 17:45

emilwidlund merged commit cf7282f into main Jan 5, 2026
16 checks passed

emilwidlund deleted the feat/credits branch January 5, 2026 17:45

Yopi mentioned this pull request Jan 5, 2026

Revert "feat(fee_credits): Ability to grant payment fee credits" #8768

Merged

feat(fee_credits): Ability to grant payment fee credits #8480

feat(fee_credits): Ability to grant payment fee credits #8480

Uh oh!

Conversation

birkjernstrom commented Dec 11, 2025

Uh oh!

vercel bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 17, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 17, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 17, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 25, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 25, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 25, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 25, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 25, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 26, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Dec 26, 2025

📦 Next.js Bundle Analysis for web

Uh oh!

frankie567 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

psincraian left a comment

Choose a reason for hiding this comment

Uh oh!

psincraian Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

psincraian Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

psincraian Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

psincraian Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 5, 2026

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Jan 5, 2026

📦 Next.js Bundle Analysis for web

Uh oh!

github-actions bot commented Jan 5, 2026

📦 Next.js Bundle Analysis for web

vercel bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 25, 2025 •

edited

Loading