Add more details to order email #8173
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Yopi
left a comment
Yopi
left a comment
There was a problem hiding this comment.
A few small comments, but otherwise nice work!
| const formattedAddress = | ||
| addressParts.length > 0 ? addressParts.join(', ') : null | ||
|
|
||
| const orderUrl = `https://polar.sh/dashboard/${organization_slug}/sales/${order_id}` |
There was a problem hiding this comment.
I think we send emails in both environments, in which case this needs to handle sandbox / prod
There was a problem hiding this comment.
Nice catch!
| class MaintainerNewProductSaleNotificationPayload(NotificationPayloadBase): | ||
| customer_name: str | ||
| customer_email: str | ||
| customer_name: str | None = None |
There was a problem hiding this comment.
Won't we still always have a customer_name? So this should just be : str
There was a problem hiding this comment.
Ah, or was the previous guarantee based on that we were passing in the customer_email?
There was a problem hiding this comment.
Ah, or was the previous guarantee based on that we were passing in the customer_email?
Exactly!
| order_date=order.created_at.isoformat(), | ||
| organization_name=organization.name, | ||
| organization_slug=organization.slug, | ||
| billing_reason=order.billing_reason, |
There was a problem hiding this comment.
I think this is typed as a non-str (OrderBillingReasonInternal), so you should be able to pass through the enum instead of a string
|
|
||
| @computed_field | ||
| def formatted_billing_reason(self) -> str: | ||
| reasons = { |
There was a problem hiding this comment.
Passing through the enum (as per the other comment) will make this a bit more complete. I think you can even get an exhaustive switch in that case (if you opt to not use a dict)
sebastianekstrom
force-pushed
the
chore/order-email-updates
branch
4 times, most recently
from
5d181b9 to
491018f
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sebastianekstrom
force-pushed
the
chore/order-email-updates
branch
from
491018f to
457b5f2
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sebastianekstrom
force-pushed
the
chore/order-email-updates
branch
from
457b5f2 to
e2dc6c8
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This reverts commit 6d26294.
📋 Summary
Related Issue: Fixes #7984
🎯 What
This PR will add some more data to the order confirmation email to give our users a quick glance of the purchase that has been made:
I also took the opportunity to redesign the email a bit.
🖼️ Screenshots/Recordings