-
Notifications
You must be signed in to change notification settings - Fork 532
Introduce spans of events #7609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
4a2bc40 to
7a93761
Compare
|
Great work on this! I wonder if we should rename |
|
@Yopi one thing I noticed during your demo was that with the pagination, the |
Good catch! It's the |
|
Then what if you have exactly 10 child events? 🤔 |
Haha exactly. If we think it's decent enough to do this without real pagination we could select one more to be able to determine if more exists and pass that to the frontend. |
|
I was reading our docs, and this type of pagination strays a bit from our promise on how we do pages (page, limit, max_count), but on the other hand I don't think it's feasible for us to get a max count for each depth. I pushed a change now that we can at least know if there are more children to load or not and maybe that's fine. I can check how this looks and behaves in the SDK. |
08cab4a to
ea44d30
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This will allow us to store events hierarchically and introduce a span-type structure where different events are related to each other and can be bundled up.
ea44d30 to
457728e
Compare
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! The API is backwards compatible in this shape, right? (i.e. everything new is optional?)
|
This would horribly break |
Precisely, everything new is optional! |
Backend:
external_idas an idempotency key. Events with the sameexternal_idare not reingestedparent_ideither as a Polarevent.idor as aexternal_id. We do the lookup on our side to allow both sides.Frontend: