feat(invoice-number): Switch to a Polar global invoice sequence #7387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By utilizing postgres SEQUENCE we can ensure that we will get a forever incrementing sequence for invoice numbers, that can be used by all organizations. During a rollback the number will not get reused, but as long as each organization has a strictly increasing number sequence it should be legally OK.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
| f""" | ||
| SELECT setval('invoice_number_seq', | ||
| COALESCE( | ||
| (SELECT MAX(CAST(SPLIT_PART(invoice_number, '-', 2) AS INTEGER)) |
Contributor
There was a problem hiding this comment.
Alternatively we could just do SELECT COUNT(*) FROM orders and start there?
Contributor
Author
|
Alternative approach: #7460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary
Related Issue: Fixes #6994
Switch to a Polar global invoice sequence instead of a per organization invoice sequence.
By utilizing postgres SEQUENCE we can ensure that we will get a forever incrementing sequence for invoice numbers, that can be used by all organizations.
During a rollback the number will not get reused, but as long as each organization has a strictly increasing number sequence it should be legally OK.
🎯 What
SEQUENCEfor invoice numbersget_next_invoice_number.🤔 Why
To avoid leaking volume information for a specific merchant, we want to have another invoice identifier.
🔧 How
🧪 Testing
uv run task testfor backend,pnpm testfor frontend)uv run task lint && uv run task lint_typesfor backend)Test Instructions
🖼️ Screenshots/Recordings
📝 Additional Notes
✅ Pre-submission Checklist