chore: Bump polars to unreleased 2025-09-20 version#1553
Merged
Conversation
eitsupi
force-pushed
the
bump-polars-20250921
branch
from
3f0fcf9 to
ee1a95f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the polars R package to use an unreleased 2025-09-20 version of polars, incorporating several upstream changes including data type system improvements and deprecations.
- Adds support for UInt128 data type and includes it in relevant tests
- Updates Decimal data type to require explicit precision/scale parameters and deprecates NULL values
- Removes the deprecated
collapse_joinsoptimization parameter from LazyFrame methods
Reviewed Changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rust/Cargo.toml | Updates polars dependency revision and adds polars-compute dependency |
| src/rust/src/datatypes.rs | Refactors Decimal type to require explicit precision/scale, adds UInt128 support |
| src/rust/src/series/export.rs | Adds UInt128 to integer export handling |
| src/rust/src/lazyframe/general.rs | Removes collapse_joins parameter from optimization toggle |
| R/datatypes-classes.R | Updates Decimal constructor with deprecation warnings for NULL values |
| R/lazyframe-frame.R | Deprecates collapse_joins parameter across LazyFrame methods |
| tests/testthat/ | Adds UInt128 test cases and updates Decimal validation tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eitsupi
commented
Sep 21, 2025
Comment on lines
+33
to
+36
| # TODO: remove polars-compute after dec128_verify_prec_scale is exposed in polars-core | ||
| polars-compute = { git = "https://github.com/pola-rs/polars.git", rev = "664656ea91291f8f4b4eb9d42af2a9da5394616e", default-features = false, features = [ | ||
| "dtype-decimal", | ||
| ] } |
Collaborator
Author
There was a problem hiding this comment.
We can remove this if pola-rs/polars#24556 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes