Skip to content

Conversation

@eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Jul 25, 2025

No description provided.

@eitsupi eitsupi added this to the 1.1.0 milestone Jul 25, 2025
@eitsupi eitsupi changed the title chore!: Bump polars chore!: Bump polars to py-1.32.0 Jul 25, 2025
@eitsupi eitsupi changed the title chore!: Bump polars to py-1.32.0 chore: Bump polars to py-1.32.0 Jul 25, 2025
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jul 25, 2025

@etiennebacher
Copy link
Collaborator

I'll have more time to contribute to this in about 2 weeks

@eitsupi eitsupi marked this pull request as ready for review July 31, 2025 09:25
Copilot AI review requested due to automatic review settings July 31, 2025 09:25

This comment was marked as outdated.

@eitsupi eitsupi requested a review from Copilot July 31, 2025 10:52

This comment was marked as outdated.

@eitsupi eitsupi requested a review from Copilot July 31, 2025 14:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the R polars package to be compatible with polars-py version 1.32.0 prerelease. The changes primarily involve adapting to underlying Polars Rust library updates, including new API changes, deprecations, and selector system modifications.

  • Updates Rust dependencies to a newer polars commit
  • Implements a new selector system with dedicated PlRSelector class
  • Updates error message formats and test expectations
  • Modifies categorical data handling to remove deprecated ordering features

Reviewed Changes

Copilot reviewed 116 out of 117 changed files in this pull request and generated 6 comments.

File Description
tests/ Updates test expectations for error messages, column ordering, and selector behavior
src/rust/ Major refactoring to implement new selector system and update polars API usage
man/ Documentation updates for deprecated parameters and new selector features
Comments suppressed due to low confidence (1)

src/rust/src/expr/selector.rs:216

  • [nitpick] The function name empty should be more descriptive. Consider renaming to empty_selector or similar to clarify its purpose in the selector context.
        Ok(dsl::empty().into())

@eitsupi
Copy link
Collaborator Author

eitsupi commented Aug 2, 2025

The documentation is not perfect, but I want to incorporate updates to the Rust side into main as soon as possible, so I'm merging it.

@eitsupi eitsupi merged commit 33682fe into main Aug 2, 2025
24 checks passed
@eitsupi eitsupi deleted the py-1.32 branch August 2, 2025 03:30
@eitsupi eitsupi changed the title feat: Update based on prelerease version of polars py-1.32.0 feat: Update based on polars py-1.32.0 Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants