-
Notifications
You must be signed in to change notification settings - Fork 41
feat: Update based on polars py-1.32.0 #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This involves a lot of big breaking changes on the Rust side, and looks like it's going to be a very tough undertaking...
|
|
I'll have more time to contribute to this in about 2 weeks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the R polars package to be compatible with polars-py version 1.32.0 prerelease. The changes primarily involve adapting to underlying Polars Rust library updates, including new API changes, deprecations, and selector system modifications.
- Updates Rust dependencies to a newer polars commit
- Implements a new selector system with dedicated PlRSelector class
- Updates error message formats and test expectations
- Modifies categorical data handling to remove deprecated ordering features
Reviewed Changes
Copilot reviewed 116 out of 117 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/ | Updates test expectations for error messages, column ordering, and selector behavior |
| src/rust/ | Major refactoring to implement new selector system and update polars API usage |
| man/ | Documentation updates for deprecated parameters and new selector features |
Comments suppressed due to low confidence (1)
src/rust/src/expr/selector.rs:216
- [nitpick] The function name
emptyshould be more descriptive. Consider renaming toempty_selectoror similar to clarify its purpose in the selector context.
Ok(dsl::empty().into())
|
The documentation is not perfect, but I want to incorporate updates to the Rust side into main as soon as possible, so I'm merging it. |
No description provided.