This repository was archived by the owner on Jul 28, 2025. It is now read-only.
refactor for pyo3 0.23.3; #125
Closed
bionicles wants to merge 1 commit into
Closed
Conversation
Author
|
regarding the note, it's possible my rust-lld not-finding-python issue is related to differences between our environments; i'm using miniconda3; seems you're using venv one nice way to address these issues would be to put a Makefile in the root of the project with clear commands to set up the python environment. maybe i just didn't set some environment variable for rust-lld to find python? I definitely have python installed, so I'm not sure what's the deal to best support windows, Justfile is potentially better cross-platform, as windows doesn't have Make |
Member
|
superseded by #128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also does:
remove once_cell dependency;
deny missing_docs;
use output_type_func in derive/tests/01
NOTE: i can't get this to compile on my rig due to issues with rust-lld not finding some python symbols, not sure what's the deal with that, but you're welcome to try to build this on your machine and see how it works.
just wanted to push what i did so others could refer to it
this would enable support for pyo3 0.23.3 using
IntoPyObjectand fix all those deprecation warningsadditionally i added a lint,
#![deny(missing_docs)]so the project won't compile with anything missing documentation, in my experience this aids accessibilityi had issues with
type_func=in the derive crate, so i changed it tooutput_type_functo make the compiler STFU, but i don't really know what that test was for; it's possible there has been some regression in the derive macro fortype_func; please explainI'm not the best at checking github notifications and am in crunch time for a project release, so if you want edits to this PR, please go ahead and edit it!
would close
#124
#119
relevant to
#112
#37
cheers, happy new year, i'm personally trying to switch more to pure rust but am still using this sometimes so just wanted to contribute local changes upstream... please give me pointers if i screwed something up!