Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap long strings #4144

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Wrap long strings #4144

merged 3 commits into from
Jul 25, 2022

Conversation

stinodego
Copy link
Contributor

Relates to #4044

I want to improve consistency for line lengths. Because there is a lot to go through, I'm chopping it up in pieces:

  • Long strings in the code (this PR)
  • Long comments
  • Long docstrings

Changes:

  • Use black to automatically wrap long strings (this will ensure compliance with black in the future).
  • Improve clarity for some of the string wrapping.

@github-actions github-actions bot added the python Related to Python Polars label Jul 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4144 (b75082f) into master (2ee2d01) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4144      +/-   ##
==========================================
+ Coverage   58.44%   58.47%   +0.02%     
==========================================
  Files         436      436              
  Lines       66888    66888              
==========================================
+ Hits        39092    39110      +18     
+ Misses      27796    27778      -18     
Impacted Files Coverage Δ
py-polars/polars/internals/construction.py 23.77% <ø> (ø)
py-polars/polars/internals/expr.py 40.95% <ø> (ø)
py-polars/polars/internals/frame.py 27.00% <ø> (ø)
py-polars/polars/internals/lazy_frame.py 26.23% <0.00%> (ø)
py-polars/polars/internals/lazy_functions.py 18.70% <ø> (ø)
py-polars/polars/internals/series.py 36.15% <ø> (ø)
py-polars/polars/internals/slice.py 25.84% <ø> (ø)
py-polars/polars/io.py 16.48% <ø> (ø)
py-polars/polars/testing.py 33.87% <ø> (ø)
py-polars/polars/utils.py 31.91% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee2d01...b75082f. Read the comment docs.

@ritchie46
Copy link
Member

Yep, seems good to me. Thanks.

@ritchie46 ritchie46 merged commit 69d1339 into pola-rs:master Jul 25, 2022
@stinodego stinodego deleted the line-length branch August 30, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants