Skip to content

fix: Unaliased constants in SQL SELECT with GROUP BY - #29367

Merged
ritchie46 merged 3 commits into
mainfrom
sql-group-by-constants
Sep 18, 2026
Merged

ritchie46 merged 3 commits into
mainfrom
sql-group-by-constants

Conversation

@ritchie46

@ritchie46 ritchie46 commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

fixes #29346

@github-actions github-actions Bot added A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 18, 2026
@ritchie46 ritchie46 changed the title fix: Unaliased constants in SQL SELECT with GROUP BY [skip ci] fix: Unaliased constants in SQL SELECT with GROUP BY Sep 18, 2026
@ritchie46
ritchie46 marked this pull request as ready for review September 18, 2026 07:34
@ritchie46
ritchie46 force-pushed the sql-group-by-constants branch from 41e7a8d to de675f5 Compare September 18, 2026 07:39
@github-actions

Copy link
Copy Markdown
Contributor

The uncompressed lib size after this PR is 56.5534 MB (at de675f5).

@ritchie46
ritchie46 merged commit b72e560 into main Sep 18, 2026
31 checks passed
@ritchie46
ritchie46 deleted the sql-group-by-constants branch September 18, 2026 08:27
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.13%. Comparing base (070ad45) to head (de675f5).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-sql/src/context.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29367      +/-   ##
==========================================
+ Coverage   82.11%   82.13%   +0.01%     
==========================================
  Files        1933     1933              
  Lines      278530   278538       +8     
  Branches     3124     3124              
==========================================
+ Hits       228725   228778      +53     
+ Misses      49019    48974      -45     
  Partials      786      786              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL: an unaliased constant in the SELECT list of a GROUP BY query raises unable to find column "literal"

1 participant