Repository navigation
fix: Apply the OVER clause to multi-argument aggregates - #29160
Merged
Merged
Conversation
ritchie46
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
orlp
as code owners
September 4, 2026 14:34
Contributor
|
The uncompressed lib size after this PR is 54.7247 MB (at |
github-actions
Bot
added
A-sql
ritchie46
changed the title
OVER clause to multi-argument aggregatesOVER clause to multi-argument aggregates
The `OVER` clause was only applied by `try_visit_unary` and a handful of hand-written aggregate visitors, so multi-argument aggregates such as `CORR`, `COVAR_POP`, `COVAR_SAMP` and `QUANTILE_CONT`/`QUANTILE_DISC` silently dropped it and aggregated over the whole frame. `ARRAY_AGG`, `STRING_AGG`, `ARRAY_INNER_PRODUCT` and UDFs had the same gap in their own visitors. Fixes #29150 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016q5BnG1jzUBLVdzSsPs5pR
github-actions
Bot
added
python
ritchie46
force-pushed
the
worktree-sql-window-partition-by
branch
from
September 4, 2026 15:51
d55e73a to
435b2ed
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29160 +/- ##
==========================================
+ Coverage 81.65% 81.67% +0.02%
==========================================
Files 1905 1905
Lines 270933 270975 +42
Branches 3105 3105
==========================================
+ Hits 221242 221331 +89
+ Misses 48906 48861 -45
+ Partials 785 783 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29150