Repository navigation
feat: Support date/integer arithmetic and decimal non-equi join comparisons - #29156
Merged
Merged
Conversation
…comparisons Two TPC-DS queries failed to plan: - q72 uses `d3.d_date > d1.d_date + 5`. Lower `date + n` / `date - n` in the SQL layer to a whole-day shift via `duration(days=n)`, matching the semantics of other SQL engines. The expression API is unchanged. - q65 compares `Decimal(38, 2)` to `Float64` inside a `join_where` predicate. `get_numeric_upcast_supertype_lossless` has no decimal arm and returned `None`, so the comparison was rejected. Route comparisons where either side is a decimal through `try_get_supertype`, as an equivalent filter would. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A3zEh6bx42AkyRP6jKvdPY
github-actions
Bot
added
A-dtype-decimal
ritchie46
changed the title
ritchie46
marked this pull request as ready for review
September 4, 2026 14:05
ritchie46
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
orlp
as code owners
September 4, 2026 14:05
Contributor
|
The uncompressed lib size after this PR is 54.7149 MB (at |
github-actions
Bot
added
python
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29156 +/- ##
==========================================
- Coverage 81.65% 81.64% -0.02%
==========================================
Files 1905 1905
Lines 270933 270965 +32
Branches 3105 3105
==========================================
- Hits 221242 221222 -20
- Misses 48906 48960 +54
+ Partials 785 783 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.