Repository navigation
Conversation
`DATE '2019-01-01'` emitted `lit(v).cast(Date)`, which polars no longer has a kernel for, so any query using the typed-literal form failed with "casting from string to date is not supported". Its `TIME` and `TIMESTAMP` siblings already parsed the string; all three now go through `parse_string_as_temporal`. The time unit `resolve_typed_literal_dtype` derives from a declared precision was also computed and then discarded, so `TIMESTAMP(3)` produced microseconds. It is now honoured. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016uVEEL5SiJifQEYPiUxszh
ritchie46
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
orlp
as code owners
August 27, 2026 10:16
github-actions
Bot
added
A-sql
Contributor
|
The uncompressed lib size after this PR is 60.4935 MB. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29007 +/- ##
==========================================
- Coverage 81.58% 81.36% -0.23%
==========================================
Files 1890 1886 -4
Lines 268762 267396 -1366
Branches 3264 3061 -203
==========================================
- Hits 219280 217564 -1716
- Misses 48637 49054 +417
+ Partials 845 778 -67 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dsprenkels
added a commit
to dsprenkels/polars
that referenced
this pull request
Sep 8, 2026
The claim that `::date`/`::timestamp` on a SQL string literal no longer works was true when written (pola-rs#28788), but pola-rs#28986/pola-rs#29007 made SQL parse string->temporal instead of casting, so those all succeed again. This commit was generated using Claude Opus 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String casts to temporal is not supported in 2.0