Repository navigation
fix: SQL follow Postgres scope strictness - #28937
Merged
Merged
Conversation
A qualified column resolved its qualifier against every registered table, not just the relations the current `FROM` declares. Inside a subquery, where the enclosing query's tables are still registered, an outer qualifier therefore bound to a table of that name instead of correlating: `x.a < t1.a` over `FROM t1 AS x` compared the inner relation against itself and quietly answered the wrong question. Shapes the subquery lowerings do not claim, such as a subquery carrying `LIMIT` or `GROUP BY`, still reach that path, so the same wrong answer was reachable for them. Record the relations each `FROM` declares and let a qualifier name only those. An alias replaces the table name, as it does in Postgres, so `t1.a` over `FROM t1 AS f` is now refused rather than resolved. A nested join is flattened rather than bound to its alias, so its own relations stay declared. Queries whose subquery shape has no lowering now fail rather than return a wrong answer; correlated `IN`, `EXISTS` and the quantified comparisons are unaffected, as they are lowered before this path is reached. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012PeS5DzwijVsijK68XXPsw
ritchie46
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
orlp
as code owners
August 24, 2026 10:05
github-actions
Bot
added
A-sql
Contributor
|
The uncompressed lib size after this PR is 60.9148 MB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made with opus 5