fix(python): Add PerformanceWarning to LazyFrame.__contains__ - #26738
Closed
anihal wants to merge 1 commit into
Closed
fix(python): Add PerformanceWarning to LazyFrame.__contains__#26738anihal wants to merge 1 commit into
anihal wants to merge 1 commit into
Conversation
`'col' in lf` silently resolved the schema via collect_schema(). All other schema-resolving properties (.columns, .dtypes, .schema, .width) already emit a PerformanceWarning; __contains__ was missed.
anihal
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
ritchie46
as code owners
February 27, 2026 04:00
Author
|
Closing — PR #26734 already covers this fix. |
anihal
changed the title
github-actions
Bot
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21917
What changed
'col' in lfsilently calledcollect_schema()without warning the user. All other schema-resolving properties (.columns,.dtypes,.schema,.width) already emit aPerformanceWarningviaissue_warning();__contains__was overlooked.Fix
Added
issue_warning(..., category=PerformanceWarning)to__contains__before thecollect_schema()call, matching the existing pattern.Tests
Extended
test_lf_propertieswith two assertions — one for a present column, one for an absent column — both asserting the warning is emitted.