Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cast to BinView before filtering Utf8View #21106

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite added needs-bench Needs a benchmark run and removed needs-bench Needs a benchmark run labels Feb 6, 2025
@coastalwhite coastalwhite added the needs-bench Needs a benchmark run label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (966f76f) to head (773392b).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-compute/src/filter/mod.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21106      +/-   ##
==========================================
- Coverage   79.27%   79.27%   -0.01%     
==========================================
  Files        1588     1588              
  Lines      226122   226136      +14     
  Branches     2593     2593              
==========================================
+ Hits       179267   179271       +4     
- Misses      46259    46269      +10     
  Partials      596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit a9192e8 into pola-rs:main Feb 6, 2025
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation needs-bench Needs a benchmark run
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants