Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Rechunk only once during join probe gather #21072

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 4, 2025

The gather of the payload after finding matches does a rechunk internally. We now rechunk eagerly (as long as 1 match is found) to avoid the repeated rechunk. This sped up query 16 in PDS-H by ~2x.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (3e70e5a) to head (2b0c7d2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21072      +/-   ##
==========================================
- Coverage   79.27%   79.26%   -0.01%     
==========================================
  Files        1585     1586       +1     
  Lines      225622   225648      +26     
  Branches     2588     2588              
==========================================
+ Hits       178865   178869       +4     
- Misses      46167    46189      +22     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 3336475 into pola-rs:main Feb 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants