refactor: Small drive-by's #20772
Merged
refactor: Small drive-by's #20772
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
ritchie46
commented
Jan 17, 2025
| @@ -311,7 +313,8 @@ fn try_build_streaming_group_by( | |||
| &mut trans_agg_exprs, | |||
| &trans_input_cols, | |||
| )?; | |||
| trans_output_exprs.push(ExprIR::new(trans_node, agg.output_name_inner().clone())); | |||
| let output_name = OutputName::Alias(agg.output_name().clone()); | |||
There was a problem hiding this comment.
The origin of OutputName can be changed during rewrite.
|
The uncompressed lib size after this PR is 39.1748 MB. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20772 +/- ##
==========================================
+ Coverage 79.74% 79.77% +0.03%
==========================================
Files 1561 1561
Lines 222012 221922 -90
Branches 2530 2530
==========================================
Hits 177049 177049
+ Misses 44381 44291 -90
Partials 582 582 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.