Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore quotes in csv comments #20306

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: Ignore quotes in csv comments #20306

merged 2 commits into from
Dec 16, 2024

Conversation

ritchie46
Copy link
Member

fixes #12440

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 16, 2024
@ritchie46 ritchie46 merged commit 64cb34d into main Dec 16, 2024
23 checks passed
@ritchie46 ritchie46 deleted the csv branch December 16, 2024 09:49
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (91ad299) to head (88f091d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20306   +/-   ##
=======================================
  Coverage   79.60%   79.61%           
=======================================
  Files        1567     1567           
  Lines      218398   218468   +70     
  Branches     2465     2465           
=======================================
+ Hits       173866   173932   +66     
- Misses      43963    43967    +4     
  Partials      569      569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unfinished quotes (also in skipped lines) result in an empty CSV with read_csv()
1 participant