fix(python): More accurate from_dicts typing/signature
#19322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
MarcoGorelli,
c-peters,
reswqa and
ritchie46
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19322 +/- ##
==========================================
- Coverage 80.24% 80.23% -0.01%
==========================================
Files 1523 1523
Lines 209524 209524
Branches 2434 2434
==========================================
- Hits 168127 168116 -11
- Misses 40842 40853 +11
Partials 555 555 ☔ View full report in Codecov by Sentry. |
dangotbanned
added a commit
to dangotbanned/polars
that referenced
this pull request
Sep 23, 2025
Closes pola-rs#24583 Downstream in `narwhals`, we discovered the typing wasn't updated alongside the runtime support added in `1.30.0` ### Related - pola-rs#22638 - pola-rs#19322 - narwhals-dev/narwhals#3148 (comment) - narwhals-dev/narwhals#3148 (comment)
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19234.
We actually accept an
Iterablefor the "data" param, not just aSequence.