-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(python): Improve DataFrame.write_database docstring #19189
docs(python): Improve DataFrame.write_database docstring #19189
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19189 +/- ##
=======================================
Coverage 79.94% 79.95%
=======================================
Files 1526 1526
Lines 208499 208499
Branches 2416 2416
=======================================
+ Hits 166692 166700 +8
+ Misses 41259 41251 -8
Partials 548 548 ☔ View full report in Codecov by Sentry. |
7d47900
to
89f5343
Compare
py-polars/polars/dataframe/frame.py
Outdated
* "adbc" - inserts using the ADBC cursor's `adbc_ingest` method. | ||
Additional options to pass to the insert method associated with the engine | ||
specified by the option `engine`. | ||
See the documentation for the appropriate method: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd omit line 3895 ("see the documentation") - the reader is already in the documentation (not the documentation of the adbc/alchemy projects, but this suggestion doesn't link to those). But good improvement otherwise :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think that that sentence is important because it makes it obvious to the user that there is an extra level of indirection (see the docs for “the appropriate method”) that they need to follow for the full info.
Either way, I deleted that sentence in 638579a.
89f5343
to
638579a
Compare
Fixes #19181
cc @alexander-beedie