Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rust): Align dates in DataFrame example with Python #18491

Merged

Conversation

xhiroga
Copy link
Contributor

@xhiroga xhiroga commented Aug 31, 2024

Aligns dates in Rust DataFrame example with Python version and standard output.

This improves consistency across documentation, preventing confusion for users.

@github-actions github-actions bot added documentation Improvements or additions to documentation rust Related to Rust Polars labels Aug 31, 2024
@xhiroga
Copy link
Contributor Author

xhiroga commented Aug 31, 2024

FYI: As shown, there is a discrepancy between the Rust code and the standard output example (as well as the Python code) in docs.

image

Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted ;)

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Sep 30, 2024

@xhiroga: Ahhh... I see there is now a conflict; could would you mind resolving?
(Apologies for the delay in merging 🙏)

@xhiroga
Copy link
Contributor Author

xhiroga commented Sep 30, 2024

@alexander-beedie Sure! I've just resolved the conflict and updated the PR.
Thanks for the heads-up :)

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Sep 30, 2024

@ritchie46, @stinodego: FYI, this one looks good to merge now :)

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (64ca265) to head (1ec8b92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18491   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files        1524     1524           
  Lines      207747   207747           
  Branches     2908     2908           
=======================================
+ Hits       165922   165924    +2     
+ Misses      41276    41274    -2     
  Partials      549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 83f0127 into pola-rs:main Sep 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants