Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix DataFrame.__getitem__ for empty list input - df[[]] #16520

Merged
merged 3 commits into from
May 27, 2024

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented May 27, 2024

Now that we have decided not to go ahead with #4924 - we can definitively say that this is a bug: the first positional parameter indicates the rows to select. Selecting no rows should give zero rows but include all columns.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 27, 2024
@stinodego stinodego changed the title fix(python): Fix DataFrame.__getitem__ for empty list input df[[]] fix(python): Fix DataFrame.__getitem__ for empty list input - df[[]] May 27, 2024
@stinodego stinodego marked this pull request as ready for review May 27, 2024 13:22
@stinodego stinodego merged commit 7aa514c into main May 27, 2024
16 of 17 checks passed
@stinodego stinodego deleted the getitem-empty branch May 27, 2024 13:37
@c-peters c-peters added the accepted Ready for implementation label Jun 3, 2024
@utkarshgupta137
Copy link
Contributor

This should've been listed as a breaking change. Obviously a user bug, but it took a long while to track it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants