Skip to content

Commit

Permalink
Needless return async issue ignores
Browse files Browse the repository at this point in the history
  • Loading branch information
stinodego committed Sep 29, 2024
1 parent 5bde915 commit 360cfa2
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 0 deletions.
9 changes: 9 additions & 0 deletions crates/polars/tests/it/io/avro/read_async.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,25 @@ async fn test(codec: Codec) -> PolarsResult<()> {
Ok(())
}

// Issue with clippy interacting with tokio. See:
// https://github.com/rust-lang/rust-clippy/issues/13458
#[allow(clippy::needless_return)]
#[tokio::test]
async fn read_without_codec() -> PolarsResult<()> {
test(Codec::Null).await
}

// Issue with clippy interacting with tokio. See:
// https://github.com/rust-lang/rust-clippy/issues/13458
#[allow(clippy::needless_return)]
#[tokio::test]
async fn read_deflate() -> PolarsResult<()> {
test(Codec::Deflate).await
}

// Issue with clippy interacting with tokio. See:
// https://github.com/rust-lang/rust-clippy/issues/13458
#[allow(clippy::needless_return)]
#[tokio::test]
async fn read_snappy() -> PolarsResult<()> {
test(Codec::Snappy).await
Expand Down
3 changes: 3 additions & 0 deletions crates/polars/tests/it/io/avro/write_async.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ async fn roundtrip(compression: Option<Compression>) -> PolarsResult<()> {
Ok(())
}

// Issue with clippy interacting with tokio. See:
// https://github.com/rust-lang/rust-clippy/issues/13458
#[allow(clippy::needless_return)]
#[tokio::test]
async fn no_compression() -> PolarsResult<()> {
roundtrip(None).await
Expand Down
4 changes: 4 additions & 0 deletions docs/source/src/rust/user-guide/io/cloud-storage.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Issue with clippy interacting with tokio. See:
// https://github.com/rust-lang/rust-clippy/issues/13458
#![allow(clippy::needless_return)]

// --8<-- [start:read_parquet]
use aws_config::BehaviorVersion;
use polars::prelude::*;
Expand Down

0 comments on commit 360cfa2

Please sign in to comment.