Improve data generation in Makefile #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
force-pushed
the
fix-makefile-data-tables-scale
branch
from
1a843c2 to
fc55983
Compare
ritchie46
approved these changes
Jun 26, 2025
r-brink
pushed a commit
to r-brink/polars-benchmark
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the benchmark with one
SCALE_FACTORlikegenerates the scale 1 test data.
Then running the benchmark with a different scale factor fails:
SCALE_FACTOR=10.0 make run-polars .venv/bin/python -m queries.polars Code block 'Run polars query 1' took: 0.00011 s q1 FAILED No such file or directory (os error 2): data/tables/scale-10.0/lineitem.parquetProblem is that the data generation with
SCALE_FACTOR=1.0creates filedata/tables/.generated, which indicatesmaketest data are generated. This file disallows generating data with a different scale factor.This fix uses the data output directory containing
SCALE_FACTORas the target.