[SessionManager] Implement off-chain proof params usage #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
relayminer
23 tasks
bryanchriswhite
previously requested changes
Aug 28, 2024
Olshansk
requested changes
Aug 29, 2024
Olshansk
requested changes
Sep 4, 2024
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 765) |
Olshansk
requested changes
Sep 6, 2024
pkg/relayer/session/proof.go
Outdated
|
|
||
| // isProofRequired determines whether a proof is required for the given session's | ||
| // claim based on the current proof module governance parameters. | ||
| // TODO_TECHDEBT: Once the on/off-chain loggers are unified, move this logic to |
There was a problem hiding this comment.
Is it overkill to just pass a logger, unify it now, and add a TECHDEBT explaining why we pas sin a logger?
There was a problem hiding this comment.
The on-chain logger cosmossdk.io/log and off-chain one github.com/pokt-network/poktroll/pkg/polylog seem to be incompatible.
I'm maybe missing something but we can't pass in a logger in both on/off-chain.
There was a problem hiding this comment.
Did you confirm that this doesn't work?
I believe this is the problem polylog was meant to solve. cc @bryanchriswhite
There was a problem hiding this comment.
I tried, but had the following:
Will sync-up with @bryanchriswhite on this.
There was a problem hiding this comment.
Updated the comments to include investigation.
There was a problem hiding this comment.
red-0ne
dismissed
bryanchriswhite’s stale review
Already discussed with Bryan about the changes that came after his last review.
bryanchriswhite
added a commit
that referenced
this pull request
Sep 16, 2024
…ke-transfer * pokt/main: [Tooling, Code Health] refactor: split Makefile into multiple files (#816) [Tooling] fix and add makefile targets (#814) [Docs] Add a debugging tip: using transaction hashes (#786) [Refactor] Replace embedded Service with ServiceId (#802) [Session,Service] Ensure SessionHeader and Service basic validation. (#782) [Tokenomics] Preparation for Global Mint Reimbursement Request (#755) [Quick PR][LocalNet] Turn off minimum-gas-prices (#805) [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801) [Documentation] Cosmovisor (#768) [CI] Add cosmovisor to container images (#796) Use a descriptive error if service ID is not found (#787) [SessionManager] Implement off-chain proof params usage (#765) [SDK] Update shannon sdk dependency (#800) [E2E Test] Remove redundant logging (#798)
bryanchriswhite
added a commit
that referenced
this pull request
Sep 16, 2024
…actor/transfer-msg_period-param * issues/657/feat/app-stake-transfer: [Tooling, Code Health] refactor: split Makefile into multiple files (#816) [Tooling] fix and add makefile targets (#814) [Docs] Add a debugging tip: using transaction hashes (#786) [Refactor] Replace embedded Service with ServiceId (#802) [Session,Service] Ensure SessionHeader and Service basic validation. (#782) [Tokenomics] Preparation for Global Mint Reimbursement Request (#755) [Quick PR][LocalNet] Turn off minimum-gas-prices (#805) [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801) [Documentation] Cosmovisor (#768) [CI] Add cosmovisor to container images (#796) Use a descriptive error if service ID is not found (#787) [SessionManager] Implement off-chain proof params usage (#765) [SDK] Update shannon sdk dependency (#800) [E2E Test] Remove redundant logging (#798)
bryanchriswhite
added a commit
that referenced
this pull request
Sep 16, 2024
…ues/657/chore/app-transfer-period * issues/657/refactor/transfer-msg_period-param: [Tooling, Code Health] refactor: split Makefile into multiple files (#816) [Tooling] fix and add makefile targets (#814) [Docs] Add a debugging tip: using transaction hashes (#786) [Refactor] Replace embedded Service with ServiceId (#802) [Session,Service] Ensure SessionHeader and Service basic validation. (#782) [Tokenomics] Preparation for Global Mint Reimbursement Request (#755) [Quick PR][LocalNet] Turn off minimum-gas-prices (#805) [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801) [Documentation] Cosmovisor (#768) [CI] Add cosmovisor to container images (#796) Use a descriptive error if service ID is not found (#787) [SessionManager] Implement off-chain proof params usage (#765) [SDK] Update shannon sdk dependency (#800) [E2E Test] Remove redundant logging (#798)
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary This PR introduces the proof params to the `RelayMiner` so it does not submit proofs when not required. The E2E and `SessionManager` tests have been updated to account for proof requirement. ## Issue The `RelayMiner`'s `SessionManager` was systematically submitting proofs on-chain whether they were required or not. This led to a state chain bloat since proofs are what takes most for the block space. Given the permissionless nature of the protocol, this causing scalability issues. - #758 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the proof params to the
RelayMinerso it does not submit proofs when not required.The E2E and
SessionManagertests have been updated to account for proof requirement.Issue
The
RelayMiner'sSessionManagerwas systematically submitting proofs on-chain whether they were required or not.This led to a state chain bloat since proofs are what takes most for the block space.
Given the permissionless nature of the protocol, this causing scalability issues.
Type of change
Select one or more:
Testing
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist