Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the TestApplication_CalculateAppRelays test #1537

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Mar 30, 2023

Description

This test is a followup to an offline discussion related to how application relays are computed.

Changes

Updating TestApplication_CalculateAppRelays to reflect:

  • Maximum relays for the max staked application for ETH at height= 90074 on mainnet

Screenshot 2023-03-29 at 7 32 47 PM

Context

  • CalculateAppRelays - Returns the maximum MaxRelays param stored in the app state used to determine MaxAppRelays at the start of every session
  • MaxAppRelays - Returns the maximum relays to serve an app in a session based on its apps and the number of nodes

Helpers

export POCKET_ENDPOINT=https://:@:

Listing all params

curl --data '{"height": 90074}' --location -X 'POST' -H 'Content-Type: application/json' "${POCKET_ENDPOINT}/v1/query/allParams" | jq

Listing all app stakes in descending order

curl --data '{"height": 90074, "opts": {"per_page":3000 } }' --location -X 'POST' -H 'Content-Type: application/json' "${POCKET_ENDPOINT}/v1/query/apps" | jq -r '.result | map({staked_tokens: .staked_tokens | tonumber}) | sort_by(-.staked_tokens) | .[].staked_tokens'

Screenshot 2023-03-30 at 11 27 38 AM

@Olshansk Olshansk added the test unit test label Mar 30, 2023
@Olshansk Olshansk added this to the Network Quality of Life milestone Mar 30, 2023
@Olshansk Olshansk self-assigned this Mar 30, 2023
@Olshansk Olshansk changed the title Update the TestApplication_CalculateAppRelays test Update the TestApplication_CalculateAppRelays test Mar 30, 2023
@Olshansk Olshansk merged commit 7cb2a8b into staging Apr 4, 2023
@Olshansk Olshansk deleted the calculate_max_relays_test branch April 4, 2023 17:36
@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Apr 4, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 4, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Update the TestApplication_CalculateAppRelays test' (04d92bc)
  • Unconventional commit detected: 'Updated a comment' (86f4527)
  • Unconventional commit detected: 'Added a test for 1000 pokt' (64f2937)
  • Unconventional commit detected: 'Another test with 1 chain' (9b28530)
  • Unconventional title detected: 'Update the TestApplication_CalculateAppRelays test' illegal 'U' character in commit message type: col=00

⚠️ Warnings

  • Please link an issue to the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium test unit test waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant