Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad and outdated links #1512

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fix bad and outdated links #1512

merged 1 commit into from
Dec 8, 2022

Conversation

bmmpxf
Copy link
Contributor

@bmmpxf bmmpxf commented Dec 6, 2022

A few documentation links were pointing to the old structure, and a few were 404ing. This PR fixes them.

@bmmpxf
Copy link
Contributor Author

bmmpxf commented Dec 6, 2022

FYI, I'm seeing that there's a GitHub action that builds the docs on GitBook. We're no longer using GitBook, so those actions can be turned off. (Not sure who handles that.)

image

Copy link
Contributor

@jessicadaugherty jessicadaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested all updated URLs to confirm they resolve to the intended host. Will check on disabling the Gitbook hooks.

@jessicadaugherty
Copy link
Contributor

Update on Gitbook integration: disabling requires account owner to 2FA so will need to figure that out before removing it from this workflow @bmmpxf

@bmmpxf
Copy link
Contributor Author

bmmpxf commented Dec 7, 2022

Update on Gitbook integration: disabling requires account owner to 2FA so will need to figure that out before removing it from this workflow @bmmpxf

Thanks! I'd guess the person who has the 2FA is @jacklaing .

It's not a blocker for this particular PR, but just something we don't need to have anymore.

@bmmpxf
Copy link
Contributor Author

bmmpxf commented Dec 7, 2022

@jessicadaugherty If you have the ability to merge this, please do whenever you get the chance, as I don't appear to have access (which is fine).

@jessicadaugherty
Copy link
Contributor

So sorry @bmmpxf thought you could do the honors yourself. Done!

@jessicadaugherty jessicadaugherty merged commit 6e5c111 into staging Dec 8, 2022
@jessicadaugherty jessicadaugherty deleted the linkfix-dec22 branch December 8, 2022 16:49
@bmmpxf
Copy link
Contributor Author

bmmpxf commented Dec 8, 2022

Thank you @jessicadaugherty !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants