Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clones and reduce check period for local cache #778

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

rem1niscence
Copy link
Contributor

local-cache has a checkPeriod variable which is approximately how many seconds it wait before checking and deleting all expired keys, lower the amount of that and enable useClones which is to store/retrieve cache variable references instead of copies for perfomance

@height
Copy link

height bot commented Mar 29, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@crisog
Copy link
Contributor

crisog commented Mar 29, 2022

local-cache has a checkPeriod variable which is approximately how many seconds it wait before checking and deleting all expired keys, lower the amount of that and enable useClones which is to store/retrieve cache variable references instead of copies for perfomance

I think you meant disable useClones?

@rem1niscence
Copy link
Contributor Author

local-cache has a checkPeriod variable which is approximately how many seconds it wait before checking and deleting all expired keys, lower the amount of that and enable useClones which is to store/retrieve cache variable references instead of copies for perfomance

I think you meant disable useClones?

yeah that

@rem1niscence rem1niscence merged commit a63cca8 into develop Mar 29, 2022
@rem1niscence rem1niscence deleted the local-cache-improvements branch March 29, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants