Change syncAllowance default value as an environment variable #158
Conversation
src/services/sync-checker.ts
Outdated
| @@ -8,6 +8,8 @@ const logger = require('../services/logger') | |||
|
|
|||
| import axios from 'axios' | |||
|
|
|||
| const DEFAULT_SYNC_ALLOWANCE: number = parseInt(process.env.DEFAULT_SYNC_ALLOWANCE) || 5 | |||
There was a problem hiding this comment.
I'd rather have all of the .env variables checked in one place and rather than silently fallback to a default, I'd rather it error out and tell you that you made a dumb mistake and forgot the var.
Probably around here:
Line 59 in bddc518
There was a problem hiding this comment.
I like having .env vars in one place—this is how I usually do it
There was a problem hiding this comment.
yep, like it too
There was a problem hiding this comment.
for now I'm doing a quick fix but an issue can be opened for that to change all the envs
| const pocketBlockTime: string = process.env.POCKET_BLOCK_TIME || '' | ||
| const relayRetries: string = process.env.POCKET_RELAY_RETRIES || '' | ||
| const databaseEncryptionKey: string = process.env.DATABASE_ENCRYPTION_KEY || '' | ||
| const defaultSyncAllowance: number = parseInt(process.env.DEFAULT_SYNC_ALLOWANCE) || -1 |
There was a problem hiding this comment.
is 0 a valid value or must always be over 0? @nymd
There was a problem hiding this comment.
0 is valid though it would be very restrictive. It should be allowed. But not blank or undefined.
There was a problem hiding this comment.
all right, then this is ready
rem1niscence
changed the title
Fixes #156