Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #108; uses altruist system as backup for sync check #115

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

nymd
Copy link
Contributor

@nymd nymd commented Jul 7, 2021

Old behaviour:

  • if fewer than 3 nodes in a session agreed on sync, no consensus was found, and ALL nodes were returned as viable nodes for the session

New behaviour:

  • if fewer than 3 nodes in a session agree, or if any of the other possible error states happen in determining sync, the altruism system is consulted
  • if altruist returns a valid blockheight, the session nodes are checked for sync against it
  • if at least one node is in consensus with that blockheight, the nodes that agree are returned
  • if no node agrees with the altruist, an empty set is returned which will trigger an automatic usage of the altruist for the data for that relay

Risky behaviour:

  • if no nodes are found to be in sync with the altruist, the set of 0 nodes will be recorded for 30 seconds in redis as sync failures and the altruism system will take over complete service for that session for that 30 seconds

@nymd nymd marked this pull request as ready for review July 7, 2021 20:10
@nymd nymd merged commit 2dd44d8 into develop Jul 7, 2021
@nymd nymd deleted the feature/backup-sync branch July 7, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant