Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T-18935 infra: change phd api key env variable #1044

Merged
merged 4 commits into from
Feb 28, 2023
Merged

T-18935 infra: change phd api key env variable #1044

merged 4 commits into from
Feb 28, 2023

Conversation

rem1niscence
Copy link
Contributor

No description provided.

@rem1niscence rem1niscence requested a review from a team as a code owner February 24, 2023 14:51
@height
Copy link

height bot commented Feb 24, 2023 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-18935" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

adshmh
adshmh requested changes Feb 24, 2023
View reviewed changes
.github/workflows/canary-ap-northeast-2.yml Outdated
@@ -34,7 +34,7 @@ jobs:
envkey_REDIS_LOCAL_TTL_FACTOR: ${{ secrets.REDIS_LOCAL_TTL_FACTOR }}
envkey_BLOCKED_ADDRESSES_URL: ${{ secrets.BLOCKED_ADDRESSES_URL }}
envkey_PHD_BASE_URL: ${{ secrets.PHD_BASE_URL }}
envkey_PHD_API_KEY: ${{ secrets.PHD_API_KEY }}
envkey_PHD_API_KEY_SERVICE_PRODUCTION: ${{ secrets.PHD_API_KEY }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the name of the secret itself going to change now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! you're totally right

@commoddity commoddity changed the title infra: change phd api key env variable T-18935 infra: change phd api key env variable Feb 24, 2023
commoddity
commoddity previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@commoddity commoddity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks Roni.

adshmh
adshmh previously approved these changes Feb 28, 2023
View reviewed changes
@rem1niscence rem1niscence dismissed stale reviews from adshmh and commoddity via 4c4098c February 28, 2023 17:07
@rem1niscence rem1niscence merged commit a556841 into develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adshmh adshmh adshmh approved these changes

@commoddity commoddity commoddity left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rem1niscence @adshmh @commoddity