T-18925 fix: removed unneeded checks for required fields from PHD Client #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to 1 task:
|
rem1niscence
previously approved these changes
Feb 23, 2023
Same. The best kind of PRs. |
commoddity
force-pushed
the
phd-client-remove-model-fields
branch
from
ccbc4ab
to
61a6cb3
Compare
rem1niscence
approved these changes
Feb 28, 2023
adshmh
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the check for required model fields in the PHD client as it's no longer relevant since the move to remove mongo (and causes hard to maintain issues if/when we change DB fields).