-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mongodb #1037
Remove mongodb #1037
Conversation
|
feat: update phd-client to use v1 endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes all look good to me. Thanks man.
@@ -275,12 +266,13 @@ describe('Pocket relayer service (unit)', () => { | |||
}) | |||
|
|||
it('throws an error when loading an invalid blockchain', async () => { | |||
axiosMock.reset() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed here? Doesn't this happen after each test case already with the added code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and that's exactly why I put it there, to remove the blockchain response so it returns 404 and mimics the not found test
Remove all references of mongodb to only keep the postgres db as the only source of truth. This is done by
Although I tried my best to not modify any logic, a small change had to be done to the
loadBlockchains
function to return the expectedError
response, besides that no other change was made to any logic