Allow more short code lobbies #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trying to generate 4 short lobby codes of only 4 characters, try 5 characters, then 6 then 7 and as a final attempt use a full lobby code. Also make lobby codes only unique per game instead of for all games combined.
Caspervw
approved these changes
Mar 17, 2025
koenbollen
approved these changes
Mar 17, 2025
internal/util/identifiers.go
Outdated
|
|
||
| ss := make([]string, chars) | ||
| for i := range chars { | ||
| if i/2%2 == 0 { |
There was a problem hiding this comment.
i/2%2 is very obscure. 😅 I ran it in a Python interpreter to see what it is, which made me more confused. Turns out, it's different in Go and Python. I think a quick comment will fix this. 😇 (And maybe a unittest?)
There was a problem hiding this comment.
Yeah I removed this now. We now just use the whole alphabet for all 4 characters. Otherwise the amount of possible lobbies was too low.
There was a problem hiding this comment.
We have had multiple games now with the issue if running out of possible lobbies.
Before this only ~24k lobbies were possible with a 4 character code. After this much more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to generate 4 short lobby codes of only 4 characters, try 5 characters, then 6 then 7 and as a final attempt use a full lobby code.
Also make lobby codes only unique per game instead of for all games combined.