Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodingKeyRepresentable conditional conformance #66

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Add CodingKeyRepresentable conditional conformance #66

merged 2 commits into from
Feb 10, 2023

Conversation

stephencelis
Copy link
Member

Fixes #65.

mbrandonw
mbrandonw approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But does this mean we need to support Swift 5.6+ now?

@stephencelis
Copy link
Member Author

I think we can add the #if swift instead. Although to be honest we prob don't need to backwards compatibility we have for much longer.

@stephencelis stephencelis merged commit 3907a94 into main Feb 10, 2023
@stephencelis stephencelis deleted the coding-key-representable branch February 10, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CodingKeyRepresentable Conformance
2 participants
@stephencelis @mbrandonw