Fix assigned static properties #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the
@DependencyClientmacro doesn't attempt to do anything with static properties.The macro bails out of looking a specific member property if the member is
static. Wouldn't make sense to try and include them in the initialiser or add the@DependencyEndpointto them, so I figured it was worth just bailing as quickly as possible on them.I did notice that some of the other unit tests, the DependencyEndpoint tests, are failing. They were failing before I did any of this work though.
As discussed in the Slack, without this, assigned static properties in the form:
static var prop = SomeValue()will crash the compiler, as they're treated the exact same asvar prop: SomeValue = SomeValue().